fix: EXPOSED-464 CurrentTimestampWithTimeZone expression does not work as a default
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joc-a
force-pushed
the
joc/exposed-464
branch
2 times, most recently
from
bffca11
to
00750b0
Compare
…ork as a default When the value of a `timestampWithTimeZone` column is set from CURRENT_TIMESTAMP, the format of the value is different than when an explicit value is set, and the column type was not handling that case before.
obabichevjb
reviewed
Aug 5, 2024
exposed-jodatime/src/main/kotlin/org/jetbrains/exposed/sql/jodatime/DateColumnType.kt
Show resolved
Hide resolved
obabichevjb
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
When the value of a
timestampWithTimeZonecolumn is set fromCURRENT_TIMESTAMP, the format of the value is different than when a different value is set as a default or a value is set during insertion, and the column type was not handling that case before for SQLite and Oracle.Detailed description:
Make
timestampWithTimeZonecolumn work whenCurrentTimestampWithTimeZoneexpression is used as a default in SQLite and Oracle.Error was being thrown before.
Modify formatters to handle when
timestampWithTimeZonecolumn is set fromCURRENT_TIMESTAMP.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues