-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
0517d0b
commit 2d68622
Showing
1 changed file
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 1,25 @@ | ||
| vuln-fix: Zip Slip Vulnerability | ||
|
|
||
| This fixes a Zip-Slip vulnerability. | ||
|
|
||
| This change does one of two things. This change either | ||
|
|
||
| 1. Inserts a guard to protect against Zip Slip. | ||
| OR | ||
| 2. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. | ||
|
|
||
| For number 2, consider `"/usr/outnot".startsWith("/usr/out")`. | ||
| The check is bypassed although `/outnot` is not under the `/out` directory. | ||
| It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. | ||
| For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; | ||
| however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. | ||
|
|
||
| Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') | ||
| Severity: High | ||
| CVSSS: 7.4 | ||
| Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-zipslip/) & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.ZipSlip) | ||
|
|
||
| Reported-by: Jonathan Leitschuh <[email protected]> | ||
| Signed-off-by: Jonathan Leitschuh <[email protected]> | ||
|
|
||
| Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 |