Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release actions #650

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix release actions #650

merged 1 commit into from
Mar 3, 2023

Conversation

wakingrufus
Copy link
Collaborator

@wakingrufus wakingrufus commented Mar 3, 2023 •
edited
Loading

VERSION_LATEST_RELEASE was getting updated too early
so the actual build to publish the plugin was trying to resolve the plugin that was not released yet

@wakingrufus wakingrufus force-pushed the fix-release branch 2 times, most recently from 78b2143 to ceb520b Compare March 3, 2023 15:20
@wakingrufus wakingrufus marked this pull request as ready for review March 3, 2023 15:21
JLLeitschuh
JLLeitschuh approved these changes Mar 3, 2023
View reviewed changes
Copy link
Owner

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wakingrufus wakingrufus merged commit ace57b3 into main Mar 3, 2023
@wakingrufus wakingrufus deleted the fix-release branch March 3, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

@Tapchicoma Tapchicoma Awaiting requested review from Tapchicoma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wakingrufus @JLLeitschuh