Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving SurfaceFinder::Find_full_hypersurface_3D method #216

Open
hmehryar opened this issue Jul 24, 2024 · 1 comment · Fixed by #214
Open

Improving SurfaceFinder::Find_full_hypersurface_3D method #216

hmehryar opened this issue Jul 24, 2024 · 1 comment · Fixed by #214
Assignees
@hmehryar
Labels
enhancement New feature or request
Milestone
JETSCAPE 4.0 Release

Comments

@hmehryar
Copy link
Collaborator

hmehryar commented Jul 24, 2024 •
edited
Loading

ToDo

  1. Memory Management:
  2. Code Modularity:
  3. Documentation:
@hmehryar hmehryar self-assigned this Jul 24, 2024
@hmehryar hmehryar linked a pull request Jul 24, 2024 that will close this issue
HMehryar code optimization surface finder #214
Merged
@hmehryar hmehryar added the enhancement New feature or request label Jul 24, 2024
@hmehryar hmehryar mentioned this issue Jul 24, 2024
Open
5 tasks
@hmehryar
Copy link
Collaborator Author

Key Changes

  1. Memory Management:
  • Replaced raw pointers with std::array for managing the cube data structure.
  • Utilized std::make_unique for creating the Cornelius object.
  1. Code Modularity:
  • Broke down the original method into smaller helper functions:
    • process_time_step
    • process_x_plane
    • process_y_plane
    • process_surface_elements
  1. Documentation:

  • Added detailed Doxygen comments for each method.

  • New Helper Functions

    • process_time_step
    • process_x_plane
    • process_y_plane
    • process_surface_elements

hmehryar added a commit that referenced this issue Jul 24, 2024
@hmehryar
improving Find_full_hypersurface_3D method resolves #216 @hmehryar
576fd58
@Hendrik1704 Hendrik1704 added this to the JETSCAPE 4.0 Release milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmehryar hmehryar

Labels
enhancement New feature or request
Projects
None yet
Milestone
JETSCAPE 4.0 Release
Development

Successfully merging a pull request may close this issue.

HMehryar code optimization surface finder hmehryar/JETSCAPE
2 participants
@hmehryar @Hendrik1704