Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3364 #3431

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Fix issue 3364 #3431

merged 10 commits into from
Aug 27, 2024

Conversation

rodrigomatosc
Copy link
Contributor

@rodrigomatosc rodrigomatosc commented Aug 26, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've change the design of Categories screen.
Before After
image image

Risk factors

What may go wrong if we merge your PR?

  • No known issue.

In what cases won't your code work?

  • No known issue.

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some comments and we ca merge after they're fixed

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.

when {
x > 0 -> " "
0 -> ""
x < 0 -> "-"
}

@ILIYANGERMANOV
Copy link
Collaborator

The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.

when { x > 0 -> " " 0 -> "" x < 0 -> "-" }

This might not be caused by your PR but we should fix it 🙏

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Aug 26, 2024
@rodrigomatosc
Copy link
Contributor Author

The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.

when { x > 0 -> " " 0 -> "" x < 0 -> "-" }

The current rule implementeg in the default card header is :

image

Would you like me to modify the implementation to match the one you indicated ?

@ILIYANGERMANOV
Copy link
Collaborator

The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.
when { x > 0 -> " " 0 -> "" x < 0 -> "-" }

The current rule implementeg in the default card header is :

image Would you like me to modify the implementation to match the one you indicated ?

Yup, with the new design not showing /- makes it confusing. I read between the lines but end goal is the Category screen to makes sense for the user

@rodrigomatosc
Copy link
Contributor Author

The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.
when { x > 0 -> " " 0 -> "" x < 0 -> "-" }

The current rule implementeg in the default card header is :
image
Would you like me to modify the implementation to match the one you indicated ?

Yup, with the new design not showing /- makes it confusing. I read between the lines but end goal is the Category screen to makes sense for the user

I agree. I’ll create a new function to return the compactBalancePrefix. Without displaying the income and expenses, it can be a bit confusing.

@ILIYANGERMANOV ILIYANGERMANOV merged commit cd58c0f into Ivy-Apps:main Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Re-design "Categories" view
2 participants