-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 3364 #3431
Fix issue 3364 #3431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some comments and we ca merge after they're fixed
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI on the Categories screen should display " " or "-" before the amount depending on whether the net balance for the category is positive.
when {
x > 0 -> " "
0 -> ""
x < 0 -> "-"
}
This might not be caused by your PR but we should fix it 🙏 |
...om.ivy.categories_CategoriesScreenPaparazziTest_snapshot Categories compact Screen[Dark].png
Outdated
Show resolved
Hide resolved
…out and remove signal from monthly balance
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.