fix dds device stream-type-and-index mapping #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Oct 13, 2024
| { | ||
| results.push_back(mfp.profile); | ||
| }); | ||
| foreach_profile( |
There was a problem hiding this comment.
Is this change still needed or can it be reverted?
There was a problem hiding this comment.
You're right that it's not needed but I think it's convenient to keep the debug line there, commented.
OhadMeir
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to improve debugging, I moved the fourcc code to rsutils (
rsutils::type::fourcc) and addedbackend_stream_profile::to_stream()allowing us to print it.But the main feature here is a bug fix:
The device-proxy maintains a mapping from
stream-type-and-indexbut it was global for all streams. I.e., if two streams share an index, the second one was not be recorded and an error was not issued. Our unit-test,test-librs-format-conversion.py, did exactly this, and I noticed it failing when I added the splitting of Y12I into two separate streams.The mapping is now per sensor.