Fix for issue #377 - #301 broke IdFTP in Active mode #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code used SendCmd, a combination of IOHandler.WriteLn(ACommand) and GetResponse([125, 150, 154]). The code after the latest changes (IndySockets#301) executed IOHandler.Write(ACommand) and GetResponse... As the capture proved, the missing CRLF triggered the timeout.
DavidIzadaR
changed the title
DavidIzadaR
changed the title
rlebeau
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code used SendCmd, a combination of IOHandler.WriteLn(ACommand) and GetResponse([125, 150, 154]).
The code after the latest changes (#301) executed IOHandler.Write(ACommand) and GetResponse...
As the capture proved, the missing CRLF triggered the timeout.
In previous comments to the Indy project for this issue (#377) I used Zoe's demo project for testing against test.rebex.net (a demo FTP site).
I also provided binary and parsed captures of the traffic for the previous code executing successfully, and for the new code failing with the timeout.
Lastly, I made a frame-by-frame comparison between both, indicating where the error was triggered (command LIST without the ).