Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIdEntityHeaderInfo.Clear() does not clear CustomHeaders property #391

Open
rlebeau opened this issue Nov 29, 2021 · 0 comments
Open

TIdEntityHeaderInfo.Clear() does not clear CustomHeaders property #391

rlebeau opened this issue Nov 29, 2021 · 0 comments
Labels
Element: HTTP Issues related to HTTP handling, TIdHTTP, TIdHTTPServer, TIdHTTPProxyServer, etc Status: Review Needed Issue needs further review to decide next status Type: Bug Issue is a bug in existing code

Comments

@rlebeau
Copy link
Member

rlebeau commented Nov 29, 2021

The TIdEntityHeaderInfo.Clear() method does not clear the contents of the FCustomHeaders member, but it does clear the contents of the FRawHeaders member.

I'm not sure if this is really a bug, or is intentional, for instance to allow user-defined headers to carry across multiple requests without having to reset them each time. But since other properties are cleared, I think CustomHeaders should act consistently.

@rlebeau rlebeau added Type: Bug Issue is a bug in existing code Element: HTTP Issues related to HTTP handling, TIdHTTP, TIdHTTPServer, TIdHTTPProxyServer, etc labels Nov 29, 2021
@rlebeau rlebeau added the Status: Review Needed Issue needs further review to decide next status label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Element: HTTP Issues related to HTTP handling, TIdHTTP, TIdHTTPServer, TIdHTTPProxyServer, etc Status: Review Needed Issue needs further review to decide next status Type: Bug Issue is a bug in existing code
Projects
None yet
Development

No branches or pull requests

1 participant