fix: reapply Safari 15 min #906
Conversation
|
I'm very worried that this ud call isn't the only thing that could trigger this issue. If we switch to target Safari 15, then future code changes could hit this issue again. I found an issue about the underlying Safari bug: babel/babel#14289. It looks like the recommended workaround is to manually enable the |
wegry
force-pushed
the
fix/reapply-safari-15-min
branch
from
08f447e
to
eeabdde
Compare
Our usage of CJS inside of ESM exports seems to generate a ReferenceError with our stack in Safari 15 when coupled with a class that's being assigned to `module.exports` within a ud defn function. Swapping our browserslist default creates quite a bit of noise in our error logging, as it changes stack trace locations and increases stack size. It also increases our output code size by roughly 1%.
wegry
force-pushed
the
fix/reapply-safari-15-min
branch
from
eeabdde
to
d297787
Compare
|
|
@Macil https://github.com/terser/terser/blob/master/CHANGELOG.md#v5176 may hint at the heart of the issue that underlies this patch. It could also explain why we hadn't necessarily seen the issue manifest in our downstream projects. |
Fix for #904. Our usage of CJS inside of ESM exports seems to generate a ReferenceError with our stack in Safari 15 when coupled with a class that's being assigned to
module.exportswithin a ud defn function.Swapping our browserslist default creates quite a bit of noise in our error logging, as it changes stack trace locations and increases stack size.
It also increases our output code size by roughly 10%.edit: bundlephobia doesn't rounds the two output sizes together, but we're in the ~1% range minified.Longer term, I'd like to remove the remainder of ud in its entirety as it doesn't work with TS and is thus blocking moving off flow.See #910.