Fixed UBSan trip in GLFW OpenGL3 demo backend #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a false UBSan trip caused by treating the element offset in `glDrawElements` as a pointer This parameter is effectively an offset but is taken as a `void*` By not storing the offset as a pointer, UBSan no longer tools the offset to check for null pointer overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #516
This resolves a false UBSan trip caused by treating the element offset in
glDrawElementsas a pointerThis parameter is effectively an offset but is taken as a
void*. By not storing the offset as a pointer, UBSan no longer tools the offset to check for null pointer overflow.OpenGL has a tendency to take offsets which are applied on the GPU as pointers, but they are just offsets so it's perfectly fine to do this.