Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_http -k option not correctly specified in ITL CheckCommand "http" #8573

Closed
peteeckel opened this issue Dec 21, 2020 · 3 comments · Fixed by #8574
Closed

check_http -k option not correctly specified in ITL CheckCommand "http" #8573

peteeckel opened this issue Dec 21, 2020 · 3 comments · Fixed by #8574
Milestone
2.14.0

Comments

@peteeckel
Copy link
Contributor

Describe the bug

The check_http plugin provides the option of specifying the option "-k", which can be used to send specific headers, multiple times, once for each header.

The CheckCommand "http" provided in /usr/share/icinga2/include/command-plugins.conf is lacking the repeat_key=true option required to address this, so it doesn't work.
@peteeckel peteeckel mentioned this issue Dec 21, 2020
Merged
@Al2Klimov
Copy link
Member

Have you actually reproduced it?

@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Dec 22, 2020
@peteeckel
Copy link
Contributor Author

I just verified that even without the repeat_key flag an array as the value for an argument does repeat.

Slightly counter-intuitive, but it's documented, so it's not an issue. Closing this.

@Al2Klimov Al2Klimov removed the needs feedback We'll only proceed once we hear from you again label Jan 11, 2021
Al2Klimov pushed a commit that referenced this issue Oct 1, 2021
@peteeckel
Make http_header repeatable (fixes #8573) (#8574)
fd9f69b 
* Made http_header repeatable (fixes #8573)

* Removed explicit repeat_key option for a default setting

* Fixed closing backtick
@icinga-probot icinga-probot bot added this to the 2.14.0 milestone Oct 1, 2021
@icinga-probot
Copy link
Contributor

icinga-probot bot commented Oct 1, 2021

Closed this issue because #8574 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

Successfully merging a pull request may close this issue.

Make http_header repeatable (fixes #8573)
2 participants
@Al2Klimov @peteeckel