Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating BTX param with units #1478

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Updating BTX param with units #1478

merged 4 commits into from
Aug 28, 2024

Conversation

JavalVyas2000
Copy link
Contributor

Updating BTX params with units to mutable. This is done to suppress the warning thrown by pyomo.

The changes take place in idaes/models/properties/activity_coeff_models/BTX_activity_coeff_VLE.py

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 added Priority:Normal Normal Priority Issue or PR property packages Issues dealing with properties labels Aug 28, 2024
andrewlee94
andrewlee94 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and should suppress a lot of annoying warnings.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (2a587ab) to head (d31722e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1478       /-   ##
==========================================
- Coverage   76.37%   76.36%   -0.01%     
==========================================
  Files         393      393              
  Lines       65086    65086              
  Branches    14426    14426              
==========================================
- Hits        49708    49705       -3     
- Misses      12816    12820        4     
  Partials     2562     2561       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 merged commit fe422c0 into IDAES:main Aug 28, 2024
68 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlee94 andrewlee94 andrewlee94 approved these changes

@bpaul4 bpaul4 bpaul4 approved these changes

@MarcusHolly MarcusHolly MarcusHolly approved these changes

Assignees

@JavalVyas2000 JavalVyas2000

Labels
Priority:Normal Normal Priority Issue or PR property packages Issues dealing with properties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JavalVyas2000 @codecov-commenter @andrewlee94 @bpaul4 @MarcusHolly