Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump extensions version to 3.4.2 #1473

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Bump extensions version to 3.4.2 #1473

merged 3 commits into from
Aug 22, 2024

Conversation

Robbybp
Copy link
Member

@Robbybp Robbybp commented Aug 18, 2024

Fixes #1470

Also fixes #1471 by adding and using a bin_directory argument to print_extensions_version.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.36%. Comparing base (9dce004) to head (68d2566).
Report is 1 commits behind head on main.

Files Patch % Lines
idaes/commands/extensions.py 16.66% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1473       /-   ##
==========================================
- Coverage   76.36%   76.36%   -0.01%     
==========================================
  Files         394      394              
  Lines       65126    65128        2     
  Branches    14426    14427        1     
==========================================
- Hits        49735    49732       -3     
- Misses      12829    12835        6     
  Partials     2562     2561       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbybp Robbybp mentioned this pull request Aug 19, 2024
Closed
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Aug 22, 2024
@ksbeattie ksbeattie enabled auto-merge (squash) August 22, 2024 18:27
@ksbeattie ksbeattie merged commit 8bf70ee into IDAES:main Aug 22, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmundt mrmundt mrmundt approved these changes

@blnicho blnicho blnicho approved these changes

@dangunter dangunter Awaiting requested review from dangunter dangunter is a code owner

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl lbianchi-lbl is a code owner

@ksbeattie ksbeattie Awaiting requested review from ksbeattie ksbeattie is a code owner

Assignees

@Robbybp Robbybp

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print_extensions_version does not handle non-standard install locations Update idaes-ext version from 3.4.0
5 participants
@Robbybp @codecov-commenter @blnicho @mrmundt @ksbeattie