Limiting pint version #1438
Merged
Limiting pint version #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
added
Priority:High
mrmundt
approved these changes
Jun 17, 2024
bpaul4
approved these changes
Jun 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1438 /- ##
==========================================
- Coverage 77.80% 77.79% -0.01%
==========================================
Files 393 393
Lines 64797 64797
Branches 14390 14390
==========================================
- Hits 50413 50410 -3
- Misses 11794 11798 4
Partials 2590 2589 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
added a commit
to lbianchi-lbl/idaes-ui
that referenced
this pull request
Jun 21, 2024
lbianchi-lbl
added a commit
to IDAES/idaes-ui
that referenced
this pull request
Jun 21, 2024
* Move testing dependencies to extras_require and remove dev target * Add pytest importorskip for optional dependencies * Use Action from PR instead of main * Remove FastAPI code and dependencies for the time being * Remove unused code causing error message shown during tests * Add pint version constraint for compat with unreleased IDAES/idaes-pse#1438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes None
Summary/Motivation:
Pint recently released v0.24 which changed some behavior in how dimensionless quantities are displayed and thus causes tests to start failing. However, v0.24 is only supported on Python 3.10 and greater, and thus we cannot switch tho the new version as we still support older version of Python.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: