Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding USD_2022 to units library as the most recently published value #1413

Merged
merged 1 commit into from
May 20, 2024

Conversation

hunterbarber
Copy link
Contributor

Fixes

Append USD_YYYY list with USD_2022 value from https://toweringskills.com/financial-analysis/cost-indices/

Summary/Motivation:

Add more up to date values for USD

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@hunterbarber
Copy link
Contributor Author

Note the conversion value for USD_2021 in the repo differs from the one published in https://toweringskills.com/financial-analysis/cost-indices/ (708.0 compared to 708.8). I imagine changing this value in the repo would require a lot of downstream changes in value assertions for costing tests, so I'm leaving as is.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.89%. Comparing base (f0c60c4) to head (b69e53c).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413       /-   ##
==========================================
- Coverage   77.89%   77.89%   -0.01%     
==========================================
  Files         394      394              
  Lines       65079    65079              
  Branches    14389    14389              
==========================================
- Hits        50695    50692       -3     
- Misses      11795    11799        4     
  Partials     2589     2588       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 requested a review from bpaul4 May 20, 2024 13:27
@andrewlee94 andrewlee94 added enhancement New feature or request Priority:Normal Normal Priority Issue or PR WaterTAP labels May 20, 2024
Copy link
Contributor

@bpaul4 bpaul4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunterbarber thank you for adding the 2022 value. We actually use 2018 as the default for most tests, so updating the 2021 value should have a small impact. Please feel free to update this value.

@andrewlee94
Copy link
Member

andrewlee94 commented May 20, 2024

@hunterbarber @bpaul4 We need to be careful about changing values like this; whilst we might not test against it, others might be using the values and this would be an unexpected change for them. If there is good cause for the change then we can consider it, but we would also need to discuss backward compatibility.

@andrewlee94 andrewlee94 enabled auto-merge (squash) May 20, 2024 13:56
@andrewlee94 andrewlee94 disabled auto-merge May 20, 2024 15:12
@andrewlee94 andrewlee94 merged commit 3cf3a84 into IDAES:main May 20, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:Normal Normal Priority Issue or PR WaterTAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants