Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack example #96

Merged
merged 7 commits into from
Nov 29, 2017
Merged

Add webpack example #96

merged 7 commits into from
Nov 29, 2017

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Nov 17, 2017

Includes a webpack example to test integration with a common build system.

Also updates the generate helpers to build the files in the correct order, so no need to create the manual file that orders them (I think). It also generates a local() block for each @font-family.

Finally, it introduces the idea of $font-prefix that lets you specify a path in your scss that will be the prefix for the url() of the individual @font-face declarations.

"name": "webpack-example",
"private": true,
"scripts": {
"build": "webpack --config webpack.config.prod.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn"t exist yet, need to create!

@@ -1,64 +1,3 @@
// For bundled font faces, we start with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, thank you

@seejamescode
Copy link
Contributor

I believe your order of @font-face declarations goes by weight first and then unicode ranges. I had it reversed because I thought that may have an affect. Are you not seeing anything different?

@joshblack joshblack merged commit d9b6c57 into IBM:master Nov 29, 2017
@joshblack joshblack deleted the add-webpack-example branch November 29, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants