Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Reorganize entire project around IBM Plex #130

Merged
merged 11 commits into from
Feb 21, 2018
Merged

[WIP] Reorganize entire project around IBM Plex #130

merged 11 commits into from
Feb 21, 2018

Conversation

seejamescode
Copy link
Contributor

@seejamescode seejamescode commented Feb 9, 2018

This is the pull request that will change this repo to revolve around IBM Plex instead of a combination with typography choices. This will focus the audience of the repo to the typeface community. When this pull request is merged, the repo will be renamed ibm/plex. A new repo called ibm/type will be created as a placeholder to redirect those still with the old link.

Adds

  • IBM Plex Sans Condensed
  • Cyrillic glyphs for IBM Plex Mono, Sans, and Serif
  • Source files
  • SCSS and CSS for all weights and variants

Removes

To-Do

  • Add missing IBM Plex Sans Condensed Cyrillic splits provided by @BoldMonday
  • Avoid Cyrillic font-face declarations for IBM Plex Sans Condensed since they are not available yet
  • Add unicode range for Cyrillic glyphs provided by @BoldMonday
  • Add intro copy and image provided by @mjabbink
  • Fix font weights for Text and heavier
  • Travis config to automated releases during merge to master
  • Remove webpack example instead for @ibm/typography (@mjabbink’s decision)

Zips to add to releases

  • Mac (OpenType).zip
  • PC (TrueType).zip
  • Web.zip
  • Source Code.zip

What to review right now: The new readme content found here. Please leave comments on this page. Anything @joshblack and @electrostaticfleece believe is off about the web development portion.

@BoldMonday
Copy link
Collaborator

The table with css weight values in the readme does not reflect the values stored in the fonts.

I don't know enough about css to judge if this is a problem.

Here are the values in the fonts themselves:
100 - IBM Plex Thin
100 - IBM Plex Thin Italic
200 - IBM Plex ExtraLight
200 - IBM Plex ExtraLight Italic
300 - IBM Plex Light
300 - IBM Plex Light Italic
400 - IBM Plex Regular
400 - IBM Plex Italic
450 - IBM Plex Text
450 - IBM Plex Text Italic
500 - IBM Plex Medium
500 - IBM Plex Medium Italic
600 - IBM Plex SemiBold
600 - IBM Plex SemiBold Italic
700 - IBM Plex Bold
700 - IBM Plex Bold Italic

@seejamescode
Copy link
Contributor Author

Hey @BoldMonday, see the accepted values in font-weight for CSS. It does not look like 450 is accepted. Would you like to send me new font files to reflect the table in the README?

@BoldMonday
Copy link
Collaborator

Hi @seejamescode We already followed the conventions with regard to weight values.

If you look at that https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight page you will see that Bold should be 700, not 800.

Having 3 weights between Regular and Bold means that we had to choose 450 for Text weight.

@seejamescode
Copy link
Contributor Author

Looking at this blog post it looks like x50 font weights will still work. I will adjust it as so.

@seejamescode
Copy link
Contributor Author

Updated details above based on meeting with @mjabbink. @davelab6, please let me know if anything seems off to you.

@BoldMonday
Copy link
Collaborator

@seejamescode Plex Sans Condensed has no support for Cyrillic yet. Possibly in 2019.

@BoldMonday
Copy link
Collaborator

BoldMonday commented Feb 14, 2018

@seejamescode I propose a different name for Woff.zip as a release, since that file contains multiple formats: woff, woff2, and eot.

Why not call it Webfonts.zip instead?

@mjabbink
Copy link
Contributor

mjabbink commented Feb 14, 2018 via email

@seejamescode
Copy link
Contributor Author

Thanks @BoldMonday! Just updated the initial message to reflect both points.

@davelab6
Copy link

davelab6 commented Feb 14, 2018 via email

@seejamescode
Copy link
Contributor Author

Hey @BoldMonday, please do one last review of the readme for us. @electrostaticfleece and @joshblack, please take one look over the branch to see if anything is off.

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great from the dev side!

One thing that could be confusing is where to put $font-prefix after reading:

The css code assumes the font directories are located in the same directory as your css directory. The location of the font directories can be changed in the scss code by declaring a path with $font-prefix.

But I'm sure this would be resolved by a simple example 😄

@BoldMonday
Copy link
Collaborator

Thanks for the update @seejamescode.

The current readme implies that there are only split webfonts for web developers, but there are the "unsplit" versions too (in woff, woff2 and eot format) which are superior when it comes to features and kerning. Hopefully you will find a way to mention them too?

Please also mention in the readme the availability of desktop versions in otf and ttf format. Do you agree @mjabbink?

@mjabbink
Copy link
Contributor

mjabbink commented Feb 21, 2018 via email

@seejamescode
Copy link
Contributor Author

Thanks y’all! Edits are reflected. We will be merging this afternoon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants