-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Reorganize entire project around IBM Plex #130
Conversation
The table with css weight values in the readme does not reflect the values stored in the fonts. I don't know enough about css to judge if this is a problem. Here are the values in the fonts themselves: |
Hey @BoldMonday, see the accepted values in font-weight for CSS. It does not look like |
Hi @seejamescode We already followed the conventions with regard to weight values. If you look at that https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight page you will see that Bold should be 700, not 800. Having 3 weights between Regular and Bold means that we had to choose 450 for Text weight. |
Looking at this blog post it looks like x50 font weights will still work. I will adjust it as so. |
@seejamescode Plex Sans Condensed has no support for Cyrillic yet. Possibly in 2019. |
@seejamescode I propose a different name for Woff.zip as a release, since that file contains multiple formats: woff, woff2, and eot. Why not call it Webfonts.zip instead? |
yes, good suggestion Paul.
Mike Abbink
—
Executive Creative Director,
Brand Experience and Design
1 917 291 7516
E-mail: [email protected]
----- Original message -----From: Paul van der Laan <[email protected]>To: IBM/type <[email protected]>Cc: Mike Abbink <[email protected]>, Mention <[email protected]>Subject: Re: [IBM/type] [WIP] Reorganize entire project around IBM Plex (#130)Date: Wed, Feb 14, 2018 3:49 AM
@seejamescode I propose a different name for Woff.zip as a release, since it should contain multiple formats: woff, woff2, and eot. Why not call it Webfonts.zip?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks @BoldMonday! Just updated the initial message to reflect both points. |
BTW when you rename a github repo it automatically sets up a redirect from
the old URLs
|
Hey @BoldMonday, please do one last review of the readme for us. @electrostaticfleece and @joshblack, please take one look over the branch to see if anything is off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great from the dev side!
One thing that could be confusing is where to put $font-prefix
after reading:
The css code assumes the font directories are located in the same directory as your css directory. The location of the font directories can be changed in the scss code by declaring a path with
$font-prefix
.
But I'm sure this would be resolved by a simple example 😄
Thanks for the update @seejamescode. The current readme implies that there are only split webfonts for web developers, but there are the "unsplit" versions too (in woff, woff2 and eot format) which are superior when it comes to features and kerning. Hopefully you will find a way to mention them too? Please also mention in the readme the availability of desktop versions in otf and ttf format. Do you agree @mjabbink? |
Agree
—
Mike Abbink
Executive Creative Director,
Brand Experience and Design
1 917 291 7516 mobile
[email protected]
—
Sent from my iPhone
using IBM Verse
On Feb 21, 2018, 11:30:25 AM, [email protected] wrote:
From: [email protected]
To: [email protected]
Cc: [email protected], [email protected]
Date: Feb 21, 2018, 11:30:25 AM
Subject: Re: [IBM/type] [WIP] Reorganize entire project around IBM Plex (#130)
Thanks for the update @seejamescode.
The current readme implies that there are only split webfonts for web developers, but there are the "unsplit" versions too (in woff, woff2 and eot format) which are superior when it comes to features and kerning. Hopefully you will find a way to mention them too?
Please also mention in the readme the availability of desktop versions in otf and ttf format. Do you agree @mjabbink?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks y’all! Edits are reflected. We will be merging this afternoon. |
This is the pull request that will change this repo to revolve around IBM Plex instead of a combination with typography choices. This will focus the audience of the repo to the typeface community. When this pull request is merged, the repo will be renamed
ibm/plex
. A new repo calledibm/type
will be created as a placeholder to redirect those still with the old link.Adds
Removes
To-Do
Add missing IBM Plex Sans Condensed Cyrillic splits provided by @BoldMonday@ibm/typography
(@mjabbink’s decision)Zips to add to releases
Mac (OpenType).zip
PC (TrueType).zip
Web.zip
Source Code.zip
What to review right now: The new readme content found here. Please leave comments on this page. Anything @joshblack and @electrostaticfleece believe is off about the web development portion.