Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with bower.json #124

Merged
merged 3 commits into from
Jun 16, 2015

Conversation

stephan-nordnes-eriksen
Copy link
Contributor

Globs are no longer supported by Bower.

Globs are no longer supported by Bower.
@stephan-nordnes-eriksen
Copy link
Contributor Author

This resolves issues I had with brunch not able to compile vex.

Ps.: There should probably be a version bump as well.

@geekjuice
Copy link
Contributor

Do you think you can point to the non-minified files in the main field`? It's part of the spec for that field. (I now realize I did not answer that part of the question in the original issue thread 😅)

@stephan-nordnes-eriksen
Copy link
Contributor Author

Ahh.. I though it was the "production" files that were supposed to go in the main files. Sure. Let me fix that.

@adamschwartz
Copy link
Contributor

I think the order of the files in main could be improved. For example, vex.css should maybe be listed before the theme files as a subtle suggestion that that’s the current order when including. Otherwise, lgtm. :shipit:

@stephan-nordnes-eriksen
Copy link
Contributor Author

Done :)

adamschwartz added a commit that referenced this pull request Jun 16, 2015
@adamschwartz adamschwartz merged commit 585739a into HubSpot:master Jun 16, 2015
@adamschwartz
Copy link
Contributor

Thank you kindly 🐴

@geekjuice
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants