Ensure the args for vex.dialog's beforeClose are identical #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version, the arguments for the beforeClose callback were different depending on the call-site. This makes them consistent.
|
This extends #116 for consistency across multiple display options |
|
Shouldn’t vex dialog just be taking advantage of vex doing this for it? |
|
@adamschwartz yup, just noticed the same thing. That last commit uses the options passed through instead of re-cloning |
|
Excellent. |
adamschwartz
added a commit
that referenced
this pull request
Apr 9, 2015
Ensure the args for vex.dialog's beforeClose are identical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, the arguments for the beforeClose callback
were different depending on the call-site. This makes them consistent.