Tall modal scroll fix #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was the only way I could see of handing this, while keeping the overlay position:fixed. If you move the overlay to position:absolute, you don't need the wrapper, but then you need to keep the overlay height dynamic via JS (how Bootstrap does it) and I don't like that. The way you have it now is nice and flexible if someone appends extra modal content |
This was referenced Feb 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this on top of my other PR. Let me know you think. This adds a full width/height content wrap around vex-content to allow the mouse wheel to scroll a long modal, no matter where the cursor is. Also, the click event gets added to the wrap as well as the overlay, so clicking off the content closes the modal. Seems to work well in my testing so far.