Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schismtracker: move to cask #44830

Merged
merged 1 commit into from
Oct 7, 2019
Merged

schismtracker: move to cask #44830

merged 1 commit into from
Oct 7, 2019

Conversation

equal-l2
Copy link
Contributor

@equal-l2 equal-l2 commented Oct 2, 2019 •
edited
Loading

As per the discussion in #44665, schismtracker will be moved from core to cask.

PR in cask: Homebrew/homebrew-cask#70048

@equal-l2 equal-l2 mentioned this pull request Oct 2, 2019
Merged
11 tasks
vitorgalvao
vitorgalvao suggested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@vitorgalvao vitorgalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to tap_migrations.json as well.

@equal-l2 equal-l2 force-pushed the move-schismtracker branch from 3ea342b to 9a4102b Compare October 3, 2019 22:47
@equal-l2
Copy link
Contributor Author

equal-l2 commented Oct 3, 2019

@vitorgalvao done.

@equal-l2
Copy link
Contributor Author

equal-l2 commented Oct 5, 2019 •
edited
Loading

Homebrew/homebrew-cask#70048 has been merged.

@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Oct 7, 2019
@SMillerDev
Copy link
Member

Thanks @equal-l2! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@fxcoudert fxcoudert merged commit 5638bb5 into Homebrew:master Oct 7, 2019
@equal-l2 equal-l2 deleted the move-schismtracker branch October 7, 2019 09:12
@lock lock bot added the outdated PR was locked due to age label Jan 7, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitorgalvao vitorgalvao vitorgalvao approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@equal-l2 @SMillerDev @vitorgalvao @fxcoudert