Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: add livecheck, head #202662

Merged
merged 1 commit into from
Dec 28, 2024
Merged

bluez: add livecheck, head #202662

merged 1 commit into from
Dec 28, 2024

Conversation

samford
Copy link
Member

@samford samford commented Dec 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

By default, livecheck isn't able to check the stable URL for bluez, so it falls back to checking the Git tags from the homepage URL. This adds a livecheck block that checks the directory listing where the stable tarball is found. Besides that, this updates the homepage to bluez.org.

While we're at it, this adds a head URL and makes sure the HEAD build works. The test fails for head builds because bluetoothctl --version returns bluetoothctl: 5.79 but version.to_s is HEAD-dfb1ffd, so I've disabled that part of the test for HEAD installations. If there's a better way to handle it, I can update the test instead.

By default, livecheck isn't able to check the `stable` URL for
`bluez`, so it falls back to checking the Git tags from the `homepage`
URL. This adds a `livecheck` block that checks the directory listing
where the `stable` tarball is found. Besides that, this updates the
`homepage` to bluez.org.

While we're at it, this adds a `head` URL and makes sure the `HEAD`
build works.
@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Dec 28, 2024
@github-actions github-actions bot added the linux-only Formula depends on Linux label Dec 28, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Dec 28, 2024
Merged via the queue into master with commit 41f4c16 Dec 28, 2024
17 checks passed
@chenrui333 chenrui333 deleted the bluez-add-livecheck-head branch December 28, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. linux-only Formula depends on Linux livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants