Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher 0.13.3 (new formula) #201096

Merged
merged 2 commits into from
Dec 14, 2024
Merged

watcher 0.13.3 (new formula) #201096

merged 2 commits into from
Dec 14, 2024

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Dec 13, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [w] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adds the library and binaries provided by watcher.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 13, 2024
Formula/w/watcher.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 14, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 14, 2024
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

Formula/w/watcher.rb Outdated Show resolved Hide resolved
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one stye issue, otherwise lgtm

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 14, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 14, 2024
@chenrui333
Copy link
Member

@dunglas, thanks for your first contribution to Homebrew-core!! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 14, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 14, 2024
Merged via the queue into Homebrew:master with commit b9fea19 Dec 14, 2024
15 checks passed
@e-dant
Copy link

e-dant commented Dec 15, 2024

This is awesome TYSVM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants