Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sf 2.69.14 #200844

Merged
merged 2 commits into from
Dec 12, 2024
Merged

sf 2.69.14 #200844

merged 2 commits into from
Dec 12, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 11, 2024
@chenrui333
Copy link
Member 

  ==> /home/linuxbrew/.linuxbrew/Cellar/sf/2.69.14/bin/sf project generate -n projectname -t empty
  /usr/bin/env: ‘node’: No such file or directory
  Error: sf: failed
  An exception occurred within a child process:
    BuildError: Failed executing: /home/linuxbrew/.linuxbrew/Cellar/sf/2.69.14/bin/sf project generate -n projectname -t empty

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 11, 2024
@daeho-ro
Copy link
Member

Shebang for run.js is changed, and this will work.

    inreplace "bin/run.js", "#!/usr/bin/env -S node --no-deprecation", "#!/usr/bin/env node"

I haven't found more natural way to fix this, how can we do?

@chenrui333
Copy link
Member

chenrui333 commented Dec 12, 2024 •
edited
Loading

we dont need to do that, now given --no-deprecation is added, we can just use the latest node instead.

relates to salesforcecli/cli#1971

@BrewTestBot @chenrui333
sf 2.69.14
9ae9334 
sf: switch to use node

Signed-off-by: Rui Chen <[email protected]>
@daeho-ro daeho-ro removed the test failure CI fails while running the test-do block label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 12, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 5b233be Dec 12, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-sf-2.69.14 branch December 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrewTestBot @chenrui333 @daeho-ro