Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unzip: update URL to patches #200777

Merged
merged 1 commit into from
Dec 11, 2024
Merged

unzip: update URL to patches #200777

merged 1 commit into from
Dec 11, 2024

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fixes #200768.

@ZhongRuoyu ZhongRuoyu added CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. CI-skip-dependents Pass --skip-dependents to brew test-bot. and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Dec 11, 2024
@ZhongRuoyu
Copy link
Member Author

Dependent failures are unrelated. Rerunning with CI-skip-dependents Pass --skip-dependents to brew test-bot. to get CI 🟢.

Error: 2 failed steps!
brew test --retry --verbose tgenv
brew test --retry --verbose tofuenv

https://github.com/Homebrew/homebrew-core/actions/runs/12272803891/job/34242800261

ZhongRuoyu added a commit that referenced this pull request Dec 11, 2024
@ZhongRuoyu
tofuenv: fix test
cd61448 
Spotted in #200777.
ZhongRuoyu added a commit that referenced this pull request Dec 11, 2024
@ZhongRuoyu
tgenv: fix test
67027ca 
Spotted in #200777.
This was referenced Dec 11, 2024
Merged
Merged
@ZhongRuoyu ZhongRuoyu enabled auto-merge December 11, 2024 11:35
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit f6323e7 Dec 11, 2024
29 of 30 checks passed
@ZhongRuoyu ZhongRuoyu deleted the unzip-patches branch December 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patch link in unzip.rb points to nowhere
2 participants
@ZhongRuoyu @SMillerDev