Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tctl: deprecate in favor of temporal #200134

Merged
merged 1 commit into from
Dec 5, 2024
Merged

tctl: deprecate in favor of temporal #200134

merged 1 commit into from
Dec 5, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Dec 5, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added go Go use is a significant feature of the PR or issue shell-completion labels Dec 5, 2024
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed shell-completion labels Dec 5, 2024
@github-actions github-actions bot added the formula deprecated Formula deprecated label Dec 5, 2024
@chenrui333 chenrui333 changed the title tctl: update go build and completion support tctl: deprecate in favor of temporal Dec 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit 5309750 Dec 5, 2024
19 checks passed
@BrewTestBot BrewTestBot deleted the tctl-completion branch December 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @daeho-ro @BrewTestBot