Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texlive: use quoted heredoc, use assert_path_exists #199951

Merged
merged 1 commit into from
Dec 4, 2024
Merged

texlive: use quoted heredoc, use assert_path_exists #199951

merged 1 commit into from
Dec 4, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Quoted heredocs work better with syntax highlighting via language injections to allow single backslash to match actual (la)tex syntax. Also a bit cleaner without all the double backslashes.

@cho-m cho-m added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Dec 4, 2024
@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels Dec 4, 2024
@cho-m cho-m marked this pull request as ready for review December 4, 2024 04:28
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit 5b749e8 Dec 4, 2024
24 checks passed
@BrewTestBot BrewTestBot deleted the texlive-quoted-heredoc branch December 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@stefanb stefanb stefanb approved these changes

Assignees
No one assigned
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. icu4c ICU use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue long build Set a long timeout for formula testing lua Lua use is a significant feature of the PR or issue perl Perl use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cho-m @stefanb @ZhongRuoyu @BrewTestBot