Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango: add livecheck #199448

Merged
merged 1 commit into from
Nov 29, 2024
Merged

pango: add livecheck #199448

merged 1 commit into from
Nov 29, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to #199446

@chenrui333 chenrui333 added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Nov 29, 2024
@chenrui333 chenrui333 requested a review from samford November 29, 2024 02:58
@github-actions github-actions bot added the long dependent tests Set a long timeout for dependent testing label Nov 29, 2024
samford
samford previously approved these changes Nov 29, 2024
View reviewed changes
Formula/p/pango.rb Outdated Show resolved Hide resolved
@samford samford added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 29, 2024
@samford samford dismissed their stale review November 29, 2024 03:19

Whoops, I didn't mean to approve this yet

@samford samford removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 29, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 29, 2024
@chenrui333 @samford
pango: add livecheck
33dec2d 
Signed-off-by: Rui Chen <[email protected]>

pango: update livecheck

Co-authored-by: Sam Ford <1584702 [email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 29, 2024
@chenrui333 chenrui333 requested a review from samford November 29, 2024 04:12
@chenrui333 chenrui333 enabled auto-merge November 29, 2024 04:20
@chenrui333 chenrui333 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into master with commit 84005a2 Nov 29, 2024
17 checks passed
@chenrui333 chenrui333 deleted the pango-livecheck branch November 29, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samford samford samford approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck long dependent tests Set a long timeout for dependent testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @samford