-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marisa 0.2.6 librime 1.12.0 (new formula) #196833
Conversation
Hi, I wander if we can download the assets from releases rather than build in this formula. |
althought haven't tested, I think it should be right (and a little troublesome) |
No, because all formula must build from source. |
fd01f52
to
5557f1b
Compare
Sorry, but I got crash when using emacs-rime with librime build from this formula. λ emacs
2024-11-14 21:03:07.339 Emacs[17341:1793670] [IMKClient subclass]: chose IMKClient_Modern
src/tcmalloc.cc:309] Attempt to free invalid pointer 0x600000a11f40
Fatal error 5: Trace/breakpoint trap
[1] 17341 abort emacs I have asked emacs-rime author @DogLooksGood for help. |
It seems the build /opt/homebrew/Cellar/librime/1.12.0 stable
λ ll lib/librime.1.12.0.dylib
-r--r--r-- 1 wangtianshu admin 2.4M Nov 14 21:18 lib/librime.1.12.0.dylib
/opt/homebrew/Cellar/librime/1.12.0 stable
λ ll /Users/wangtianshu/Downloads/librime/dist/lib/librime.1.12.0.dylib
-rwxr-xr-x 1 wangtianshu staff 7.2M Nov 11 22:57 /Users/wangtianshu/Downloads/librime/dist/lib/librime.1.12.0.dylib |
Indeed, the file size differ 3 times but I have no idea. 🥲 |
downloaded file is a universe arch (support amd64 and arm64), so it should be larger reasonably. |
This is reasonable. I might try manually build librime to see if emacs-rime works properly, but I can't guarantee when I'll have the time to do so. |
As @carlocab mentioned, library itself is ok and it does not have a problem. Maybe I miss something 🤔 |
I understand, but it should be possible to mimic what emacs-rime does in the background to replicate the crash, no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging as-is for now and fixing emacs-rime integration in a follow-up.
Agree, I will try this after changing my pc but also need help 😆 |
Should we open an issue for emacs-rime integration, and I wonder how can I help to fix this error. |
All crash stacktraces look like this
Only leveldb is linked to tcmalloc.
Break on
Debug prints from dyld:
It's likely due to the leveldb depending on tcmalloc. edit: For reference, Debian's libleveldb does not depend on libtcmalloc so I consider this a packaging error by Homebrew. Introduced here. Please consider reporting this to Homebrew. Originally posted by @ksqsf in rime/librime#963 (comment) |
Does removing the diff --git a/Formula/l/leveldb.rb b/Formula/l/leveldb.rb
index e7560b92577..3bad433fd35 100644
--- a/Formula/l/leveldb.rb
b/Formula/l/leveldb.rb
@@ -18,7 18,6 @@ class Leveldb < Formula
end
depends_on "cmake" => :build
- depends_on "gperftools"
depends_on "snappy"
def install and doing You may need to do
in order to do this. |
Yes, removing the Maybe related: https://trac.macports.org/ticket/68775#no1 |
It seems that the bug was reported long ago. |
Is there anything Homebrew can do to fix this problem temporarily? |
Looks like we had another PR that tried to disable Back then it wasn't clear that was a good idea, but discussion here has persuaded me otherwise. Feel free to create a new version of that PR; I am 👍 on that change now (assuming CI passes). |
I think this should be fixed now with
|
Confirmed |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?