Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use ubuntu-latest #196774

Merged
merged 1 commit into from
Nov 28, 2024
Merged

ci: use ubuntu-latest #196774

merged 1 commit into from
Nov 28, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 5, 2024 •
edited
Loading

Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubuntu-latest is equivalent to 22.04 right now so this does not change anything

Our ubuntu 22.04 docker image is still used (this has not been modified)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka
ci: use ubuntu-latest
d657da2 
Align CI setup with what has been done in Homebrew/brew#18704
Use ubuntu-latest when the ubuntu version does not matter.
ubunut-latest is equivalent to 22.04 right now so this does not change anything

Our ubuntu 22.04 docker image is still used (this has not been modified)
@iMichka iMichka requested review from a team and MikeMcQuaid as code owners November 5, 2024 22:17
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Nov 5, 2024
@iMichka iMichka marked this pull request as draft November 5, 2024 22:29
@iMichka
Copy link
Member Author

iMichka commented Nov 5, 2024

Moving to draft, I realised there is some other code here that hard-codes the runner name: https://github.com/Homebrew/brew/blob/master/Library/Homebrew/dev-cmd/dispatch-build-bottle.rb#L68

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

@Bo98
Copy link
Member

Bo98 commented Nov 6, 2024 •
edited
Loading

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

Anything that's strictly Homebrew/core specific should generally live in Homebrew/core (like brew determine-rebottle-runners is). brew dispatch-build-bottle was generalised enough to work with third-party taps due to the --tap= and --workflow= arguments.

However dispatch-build-bottle doesn't setup a Docker container so it probably shouldn't be changed for the reason of third-party taps. We made container setup Homebrew/core specific and do it within the workflow itself.

@iMichka iMichka marked this pull request as ready for review November 6, 2024 19:30
@iMichka
Copy link
Member Author

iMichka commented Nov 6, 2024

We will have to make a change in brew too. Wondering if there is a way to make this slightly more robust (and not having to look at two different places for that logic).

Anything that's strictly Homebrew/core specific should generally live in Homebrew/core (like brew determine-rebottle-runners is). brew dispatch-build-bottle was generalised enough to work with third-party taps due to the --tap= and --workflow= arguments.

However dispatch-build-bottle doesn't setup a Docker container so it probably shouldn't be changed for the reason of third-party taps. We made container setup Homebrew/core specific and do it within the workflow itself.

Makes sense, thanks for the explanation.

@iMichka iMichka removed the automerge-skip `brew pr-automerge` will skip this pull request label Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 28, 2024
@iMichka iMichka added this pull request to the merge queue Nov 28, 2024
@iMichka
Copy link
Member Author

iMichka commented Nov 28, 2024

Merging as this got approved. Let's see how this goes.

@github-actions github-actions bot removed the stale No recent activity label Nov 28, 2024
Merged via the queue into master with commit 94338ad Nov 28, 2024
32 checks passed
@iMichka iMichka deleted the ci branch November 28, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

@carlocab carlocab carlocab approved these changes

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iMichka @Bo98 @MikeMcQuaid @carlocab @p-linnane