migrate 3.0.1 (new formula) #13804
Closed
migrate 3.0.1 (new formula) #13804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, the test failed on fetch from a GitHub release, which is public. Maybe a rate limit issue? |
fxcoudert
requested changes
May 22, 2017
| @@ -0,0 1,16 @@ | |||
| class Migrate < Formula | |||
| desc "Database migrations. CLI and Golang library." | |||
There was a problem hiding this comment.
One sentence only, not final period
| end | ||
|
|
||
| test do | ||
| system "#{bin}/migrate", "-version" |
There was a problem hiding this comment.
We would also need a test that does more that output version number
fxcoudert
requested changes
May 22, 2017
| sha256 "17e19678e930d4a48114937fb07300c107088d86a80c798630fabc08d32ee4ee" | ||
|
|
||
| def install | ||
| mv "migrate.darwin-amd64", "migrate" |
There was a problem hiding this comment.
Our policy is that formulae in the core tap (homebrew/core) must be open-source and either built from source or produce cross-platform binaries (e.g. Java). Binary-only formulae should go to Homebrew Cask.
|
Thanks, I understand the comments. Unfortunately I didn't manage to get all the dependencies and build the binary locally. I will reopen this ticket if I find a way to fix it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This PR adds Formula for https://github.com/mattes/migrate
Closes mattes/migrate#156