-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make String.indexOf actually conform to some specification #11569
Conversation
Js, Hl, Cpp and Jvm pass. Eval, Php and Python fail with this:
Neko fails with those plus one more:
Lua fails like neko plus one more (which is already tracked in #11567):
|
I have fixed Eval and the implementation on |
Fixed python and neko as well. I don"t have local php and lua installations, but I"ll attempt a blind fix on PHP at least. |
Documenting this crap is harder than implementing it... I hope I got all the intricacies right now. This whole special situation with |
Coming from #8370, let"s see how our targets conform to JS/Java specification. There"s a wonky corner case here with the empty search string, where even MDN admits that "Searching for an empty search string produces strange results."
Edit: Results are in:
Closes #8365
Closes #11567