Use available terminal columns instead of hardcoded 80 columns #11404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is missing the dune entry. And I just tested, works for me. But I don"t think it should call |
|
Whoops, aborted Thanks for testing! |
kLabz
force-pushed
the
feature/terminal-width
branch
from
829c518 to
b97f4e0
Compare
Simn
reviewed
Nov 22, 2023
src/compiler/args.ml
Outdated
| @@ -2,8 +2,16 @@ open Globals | |||
| open Common | |||
| open CompilationContext | |||
|
|
|||
| let terminal_width = ref None | |||
| let get_columns = match !terminal_width with | |||
There was a problem hiding this comment.
This isn"t a function and executes immediately, so the terminal_width above is useless.
There was a problem hiding this comment.
damn, I knew I shouldn"t hurry to deal with it before getting out x_x
There was a problem hiding this comment.
Nice, didn"t know about lazy
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
…oundation#11404) * Use available terminal columns instead of hardcoded 80 columns * hotfix on phone * embrace laziness --------- Co-authored-by: Rudy G <[email protected]> Co-authored-by: Simon Krajewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/cryptosense/terminal_size, detect available terminal columns instead of hardcoded 80 columns when possible. Helps with help messages, for example.
Haven"t tested on windows myself