-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haxelib version testing #5920
Comments
I think that"s a feature, comparing semver versions as float is terrible. |
Could we not simply handle it (by detecting that a semver with a small regexp ? |
(I think we can actually detect 3.1 vs 3.10 since it"s at the AST level) |
That"s not haxelib specific, all defines are strings, so applying numerical comparison on them doesn"t make sense. Though it would be useful to have, |
@ibilon I know that defines are strings in Haxe I think that silently failing on float comparison is much more troublesome than implementing some dynamic comparison. If we assume that 3.3 == "3.3" and compare the float string against the version it should work quite well |
Only if there"s only one digit though, |
At the moment the parser does the exact opposite: If it finds |
I used (some long time ago) to be able to do the following:
#if (mylib >= 3.2) ... #end
This does not seem to be working anymore with float literal. String literal works however.
The text was updated successfully, but these errors were encountered: