Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change blocking pull to callback #308

Merged
merged 4 commits into from
Jun 10, 2022
Merged

change blocking pull to callback #308

merged 4 commits into from
Jun 10, 2022

Conversation

emduc
Copy link
Contributor

@emduc emduc commented Jun 10, 2022

addresses a bug for real android phone where the futures never resolve. Making the pull method blocking would then crash the app.

Ahayderi
Ahayderi approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@Ahayderi Ahayderi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast bug fix!

@emduc emduc merged commit a3817b5 into main Jun 10, 2022
@emduc emduc deleted the fix-pull-blocking-bug branch June 10, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahayderi Ahayderi Ahayderi approved these changes

@wiam8 wiam8 wiam8 approved these changes

@Adrinels Adrinels Awaiting requested review from Adrinels

@AlSchlo AlSchlo Awaiting requested review from AlSchlo

@Lindt19 Lindt19 Awaiting requested review from Lindt19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emduc @Ahayderi @wiam8