Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add custom log level support for common_telemetry::init_default_ut_logging() #864

Merged
merged 1 commit into from
Jan 11, 2023
Merged

chore: add custom log level support for common_telemetry::init_default_ut_logging() #864

merged 1 commit into from
Jan 11, 2023

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented Jan 11, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add custom log level support for common_telemetry::init_default_ut_logging()

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@e1ijah1
Copy link
Contributor Author

e1ijah1 commented Jan 11, 2023

cc @killme2008 @evenyag @waynexia Please take a look if you are available.

waynexia
waynexia approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #864 (1c80b02) into develop (a9b42b4) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #864       /-   ##
===========================================
- Coverage    86.32%   86.17%   -0.16%     
===========================================
  Files          422      422              
  Lines        55668    55669        1     
===========================================
- Hits         48056    47971      -85     
- Misses        7612     7698       86
Flag Coverage Δ
rust 86.17% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/telemetry/src/logging.rs 88.50% <100.00%> ( 0.13%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 50.00% <0.00%> (-15.87%) ⬇️
src/meta-srv/src/handler/collect_stats_handler.rs 81.08% <0.00%> (-13.52%) ⬇️
tests-integration/src/test_util.rs 87.08% <0.00%> (-12.45%) ⬇️
src/servers/src/error.rs 34.54% <0.00%> (-7.28%) ⬇️
src/frontend/src/table/scan.rs 85.18% <0.00%> (-5.56%) ⬇️
src/sql/src/parser.rs 79.39% <0.00%> (-2.02%) ⬇️
src/meta-srv/src/service/heartbeat.rs 86.17% <0.00%> (-1.07%) ⬇️
src/common/substrait/src/df_logical.rs 77.89% <0.00%> ( 0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

killme2008
killme2008 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 0e8411c into GreptimeTeam:develop Jan 11, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@e1ijah1 @paomian
chore: add custom log level support for `common_telemetry::init_defau…
723cab1 
…lt_ut_logging()` (GreptimeTeam#864)

chore: improve default ut logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e1ijah1 @killme2008 @waynexia