feat: support for show full tables #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
reviewed
Sep 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2410 /- ##
===========================================
Coverage 77.58% 84.41% 6.83%
===========================================
Files 717 727 10
Lines 112751 115113 2362
===========================================
Hits 87474 97171 9697
Misses 25277 17942 -7335 |
|
@fengjiachun @niebayes PTAL |
evenyag
reviewed
Sep 16, 2023
|
@evenyag PTAL |
evenyag
reviewed
Sep 20, 2023
killme2008
reviewed
Sep 22, 2023
|
Thank u for your contribution @Lilit0x |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: added show tables command * fix(tests): fixed parser and statement unit tests * chore: implemeted display trait for table type * fix: handled no tabletype and error for usopprted command in show databse * chore: removed full as a show kind, instead as a show option * chore(tests): fixed failing test and added more tests for show full * chore: refactored table types to use filters * fix: changed table_type to tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Added support for
SHOW FULL TABLES.Please explain IN DETAIL what the changes are in this PR and why they are needed:
The changes are to support listing all tables and table types in the default schema in greptimedb. The implementation is similar to MySQL.
Edit:
Checklist
#2372