This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Initialize Anthos on Bare Metal version in a reusable environment variable #190
Merged
michael-chi
merged 16 commits into
GoogleCloudPlatform:main
from
michael-chi:fix_anthos_version_mgmt
Sep 25, 2023
Merged
Initialize Anthos on Bare Metal version in a reusable environment variable #190
michael-chi
merged 16 commits into
GoogleCloudPlatform:main
from
michael-chi:fix_anthos_version_mgmt
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix_bmctl_version
ferrarimarco
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please fix linting errors? Thanks!
ferrarimarco
changed the title
Fix anthos version mgmt
Initialize Anthos on Bare Metal version in a reusable environment variable
Sep 22, 2023
ferrarimarco
suggested changes
Sep 22, 2023
ferrarimarco
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANTHOS_VERSION
variable incommon.sh
ANTHOS_VERSION
instead of hard coding version