-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add appengine maven sample for jdk 21 #9432
Conversation
TODO: Once a new version of shared-configurations has been published, update the POM. |
Please assign after PR is ready for review. |
Next error:
It looks like v1.2.1 is not available on maven central: https://repo1.maven.org/maven2/com/google/cloud/samples/shared-configuration/ |
I agree, the most current version available is 1.2.0. Can you rebuild this PR using v1.2.0? |
Thanks for the question, @telpirion. v1.2.0 brings in an older version of the jacoco plugin (v0.8.7) which isn't compatible with java 21 and results in the following issue:
We are looking for v1.2.1 because it contains an update of jacoco 0.8.12 which supports java 21 (https://github.com/GoogleCloudPlatform/java-repo-tools/releases/tag/v1.2.1). However, it looks like the github release was published but the actual release job of the artifact to maven central didn't get kicked off. |
Description
For b344685188
The sample in https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/appengine-java8/helloworld still contains instructions for Java 8. Running the sample as-is results in alongside instructions in https://cloud.google.com/appengine/docs/standard/java-gen2/using-maven alongside the helloworld sample in java-docs-samples:
The official documentation page describes Java 8 as being out of support as of Jan, 2024.
This PR introduces sample that is compatible with the latest LTS (JDK 21).
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only