Add useful comments to all the changes

GoogleCloudPlatform · Jul 24, 2024 · 276d12e · 276d12e
1 parent 849fb62
commit 276d12e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/perfmetrics/scripts/continuous_test/gcp_ubuntu/e2e_tests/build.sh b/perfmetrics/scripts/continuous_test/gcp_ubuntu/e2e_tests/build.sh
@@ -22,6  22,8 @@ readonly SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE=true
 readonly RUN_TEST_ON_TPC_ENDPOINT=false
 readonly PROJECT_ID="gcs-fuse-test-ml"
 readonly BUCKET_LOCATION=us-central1
 
 # This flag, if set true, will indicate to the underlying script, to customize for a presubmit-run.
 readonly RUN_TESTS_WITH_PRESUBMIT_FLAG=false
 
 cd "${KOKORO_ARTIFACTS_DIR}/github/gcsfuse"

diff --git a/perfmetrics/scripts/continuous_test/gcp_ubuntu/e2e_tests/tpc_build.sh b/perfmetrics/scripts/continuous_test/gcp_ubuntu/e2e_tests/tpc_build.sh
@@ -23,6  23,8 @@ readonly RUN_TEST_ON_TPC_ENDPOINT=true
 # TPC project id
 readonly PROJECT_ID="tpczero-system:gcsfuse-test-project"
 readonly BUCKET_LOCATION="u-us-prp1"
 
 # This flag, if set true, will indicate to underlying script to customize for a presubmit run.
 readonly RUN_TESTS_WITH_PRESUBMIT_FLAG=false
 
 cd "${KOKORO_ARTIFACTS_DIR}/github/gcsfuse"

diff --git a/perfmetrics/scripts/presubmit_test/pr_perf_test/build.sh b/perfmetrics/scripts/presubmit_test/pr_perf_test/build.sh
@@ -20,6  20,8 @@ readonly RUN_E2E_TESTS_ON_INSTALLED_PACKAGE=false
 readonly SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE=true
 readonly BUCKET_LOCATION=us-west1
 readonly RUN_TEST_ON_TPC_ENDPOINT=false
 
 # This flag, if set true, will indicate to underlying script to customize for a presubmit run.
 readonly RUN_TESTS_WITH_PRESUBMIT_FLAG=true
 
 curl https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/pulls/$KOKORO_GITHUB_PULL_REQUEST_NUMBER >> pr.json

diff --git a/tools/integration_tests/operations/operations_test.go b/tools/integration_tests/operations/operations_test.go
@@ -181,7  181,7 @@ func TestMain(m *testing.M) {
 	// Note: We are not testing specifically for implicit-dirs because they are covered as part of the other flags.
 	flagsSet := [][]string{}
 
-	// Enable experimental-enable-json-read=true case for non-presubmit runs.
 	// Enable experimental-enable-json-read=true case, but for non-presubmit runs only.
 	if !setup.IsPresubmitRun() {
 		flagsSet = append(flagsSet, []string{
 			// By default, creating emptyFile is disabled.

diff --git a/tools/integration_tests/run_e2e_tests.sh b/tools/integration_tests/run_e2e_tests.sh
@@ -35,6  35,7 @@ INTEGRATION_TEST_TIMEOUT=70m
 
 RUN_TESTS_WITH_PRESUBMIT_FLAG=false
 if [ $# -ge 5 ] ; then
   # This parameter is set to true by caller, only for presubmit runs.
   RUN_TESTS_WITH_PRESUBMIT_FLAG=$5
 fi
 
@@ -51,6  52,7 @@ if [ "$SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE" == true ]; then
   echo "Changing the integration test timeout to: $INTEGRATION_TEST_TIMEOUT"
 fi
 
 # Pass flag "-presubmit" to 'go test' command and lower timeout for presubmit runs.
 if [ "$RUN_TESTS_WITH_PRESUBMIT_FLAG" == true ]; then
   PRESUBMIT_RUN_FLAG="-presubmit"
   if [ "$SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE" == true ]; then
@@ -59,7  61,7 @@ if [ "$RUN_TESTS_WITH_PRESUBMIT_FLAG" == true ]; then
     INTEGRATION_TEST_TIMEOUT=60m
   fi
   echo "Changing the integration test timeout to: $INTEGRATION_TEST_TIMEOUT"
-  echo "Setting the flag to mark run as presubmit-run."
   echo "This is a presubmit-run."
 fi
 
 readonly RANDOM_STRING_LENGTH=5