Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update lint deps and use implicit configuration #751

Merged
merged 13 commits into from
Feb 1, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Jan 31, 2022

This fixes tons of editor bugs I had regarding jsx, eslint parsing, etc ...

Because the eslint commands were configured in a non-standard way, eslint VS code had absolutely no f'in idea what was going on :) I fixed that by making a ton of .eslintrc.js files in the proper directories.

Oh, I also removed babel.

@connorjclark connorjclark changed the title chore(deps): update eslint to 8.8.0, and update friends chore(deps): update lint deps and use implicit configuration for eslint Jan 31, 2022
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

one nit

},
parser: 'babel-eslint',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and the 2020 are in the root config.

can you just implicitly adopt those... and i guess flip off sourceType and globalReturn explicitly in this ui file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed parser.

I can't figure our how parserOptions would be merged, so I'll just leave that as-is.

@connorjclark connorjclark changed the title chore(deps): update lint deps and use implicit configuration for eslint chore(deps): update lint deps and use implicit configuration Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants