Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use esbuild instead of parcel, upgrade to node 14 #738

Merged
merged 21 commits into from
Jan 24, 2022
Merged

Conversation

connorjclark
Copy link
Collaborator

Lighthouse 9.x needs Node 14. However, Parcel v1 does not work in 14 , and Parcel v2 proved too difficult a migration[1], so let's use esbuild.

There's a esmodule-only plugin used in this PR that requires an upgrade to Node 14 too, so doing that all in the same PR.

[1] some chat logs

  • means LHCI needs to bump from node 12->14
  • parcel v1 doesnt work in node 14 (no precompiled gyp binaries local compile fails)
  • parcel v2 it is!
  • yarn workspaces hoists common deps to root node_modules, which flabbergasts parcel v2
  • ok, fine, yarn workspaces has a "nohoist" thing, let's use that
  • "nohoist" doesn't seem to work at all ... was fixed in yarn 2...

@connorjclark
Copy link
Collaborator Author

Also gonna need to upgrade to TS 4 first, but I think we can do that in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant