Add default behavior to ggshield secret ignore #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #960 /- ##
==========================================
Coverage 91.54% 91.65% 0.10%
==========================================
Files 178 178
Lines 7372 7383 11
==========================================
Hits 6749 6767 18
Misses 623 616 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
salome-voltz
force-pushed
the
salomevoltz/add-ignore-hash-cmd
branch
from
fac18a6
to
dd2ba42
Compare
agateau-gg
requested changes
Sep 12, 2024
changelog.d/20240912_120216_salome.voltz_add_ignore_hash_cmd.md
Outdated
Show resolved
Hide resolved
salome-voltz
force-pushed
the
salomevoltz/add-ignore-hash-cmd
branch
3 times, most recently
from
14ed6f0
to
b1050a6
Compare
agateau-gg
approved these changes
Sep 13, 2024
salome-voltz
force-pushed
the
salomevoltz/add-ignore-hash-cmd
branch
from
b1050a6
to
ef6bb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Command
ggshield secret ignorehad no default behavior.What has been done
Default behavior is now :
ggshield secret ignore MATCHto ignore a secret using its hash. There is also an optional option--nameto name the secret in thegitguardian.yaml.Validation
ggshield secret ignore MATCH --name NAMEgitguardian.yamlPR check list
skip-changeloglabel has been added to the PR.