Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messenger: added the ability to limit individual messages to 50 people #1838

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Messenger: added the ability to limit individual messages to 50 people #1838

merged 2 commits into from
Jun 21, 2024

Conversation

ali-ichk
Copy link
Contributor

Description

Added the ability to check if the Individual target is used and if the participant count is greater than 50. If yes, return a warning and ask the creator to select less than 50 individuals and try again.

@SKuipers SKuipers added this to the v28 milestone Jun 7, 2024
SKuipers
SKuipers approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@SKuipers SKuipers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ali, I'm going to merge and test this. Generally, with one-off return messages, we can use the $page->return->addReturns() method directly on the page, rather than adding it to the global list. I'll make this change post-merge.

@SKuipers SKuipers merged commit 47464c6 into GibbonEdu:v28.0.00 Jun 21, 2024
5 checks passed
@ali-ichk
Copy link
Contributor Author

Thanks, Sandra. Will definitely keep a note of it. Cheers!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKuipers SKuipers SKuipers approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v28
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-ichk @SKuipers