Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reafactoring Tables #821

Open
22 of 25 tasks
SKuipers opened this issue Mar 26, 2019 · 23 comments
Open
22 of 25 tasks

Reafactoring Tables #821

SKuipers opened this issue Mar 26, 2019 · 23 comments
Labels
help wanted
Projects
v18.0.00 (Bo Lo Bao) v19.0.00 (Cha Chaan Teng) v20.0.00 (Ding Ding Che) v21.0.00 (Ee Gah)

Comments

@SKuipers
Copy link
Member

SKuipers commented Mar 26, 2019 •
edited by rossdotparker
Loading

Along with our ongoing refactoring, we've been updating the HTML tables in Gibbon to use a set of PHP classes. This gives us the flexibility to add in better pagination, filtering and sorting, as well as make them mobile-responsive (soon!).

Table OOification is likely the most complicated refactoring so-far. For beginners, see #696 and #820 for a great starting point. Otherwise, give a shout with any questions, since the docs likely don't cover every use case 😅

 

Info

Here's some info if you'd like to help refactor some tables in Gibbon:

👀 Check out the ooification guide or the codebase for examples

👇 Pick a module that hasn't been started yet

💬 Reply here to let us know which module you're working on. We can also invite you to join the tracker spreadsheet, send an email to: [email protected]

:octocat: PR your changes when they're done, ideally one PR per module. More info here.

 

Additional Modules
@SKuipers SKuipers added this to In Progress in v18.0.00 (Bo Lo Bao) Mar 26, 2019
@SKuipers SKuipers pinned this issue Mar 26, 2019
@rossdotparker
Copy link
Member

Great work here Sandra. Hopefully this proves as well attendance as the breadcrumbs work: certainly this model of openly and clearly sharing the scope of the work and requesting input, seems like a great way to go. Is it worth adding a link to the list of core tables that we are working on too?

@SKuipers
Copy link
Member Author

Yep! Many of the core tables have varying difficulties from “seems okay” to “absolutely ridiculous” 😆 so I’m going to take a look and triage them a bit more before adding to the list.

@leofreitas
Copy link
Member

Hi, I made my first Table OOification in module Policies (GibbonEdu/module-policies#3).

@SKuipers
Copy link
Member Author

SKuipers commented Apr 3, 2019

Awesome, thanks Leo! I'm going to check it out this afternoon 👍

@jimbo8098
Copy link
Contributor

I'm gonna steal badges if you guys are ok with that?

@rossdotparker
Copy link
Member

I'm gonna steal badges if you guys are ok with that?

Jump right in @jimbo8098!

@jimbo8098
Copy link
Contributor

On it! You guys really have been busy!

@SKuipers SKuipers moved this from In Progress to General Roadmap in v18.0.00 (Bo Lo Bao) May 22, 2019
@jimbo8098
Copy link
Contributor

jimbo8098 commented May 22, 2019 •
edited
Loading

Badges has been completed as of yesterday fyi. A PR is awaiting approval for it atm. I did need to update core to add the domain for the module but both PRs are merged with master and v18.0.00 as the case may be.

@jimbo8098
Copy link
Contributor

Working on Info Grid now

@SKuipers
Copy link
Member Author

Awesome, thanks!

@jimbo8098
Copy link
Contributor

Finished info grid GibbonEdu/module-infoGrid#6

@jimbo8098
Copy link
Contributor

Gonna grab house points next.

@SKuipers SKuipers added this to General Roadmap in v19.0.00 (Cha Chaan Teng) Jun 20, 2019
@jimbo8098
Copy link
Contributor

Must admit, kind of left this be after my last post due to other projects, however going to work on House Points today. Long time coming!

@SKuipers
Copy link
Member Author

Awesome 😃 There were some unreleased changed on the House Points develop branch, so I've noted these in the changelog and pushed a v1.3.02 release. https://github.com/SKuipers/gibbon-house-points

@leofreitas
Copy link
Member

I'm finishing Credentials. PR in next week!

@SKuipers
Copy link
Member Author

I'm finishing Credentials. PR in next week!

Brilliant, thanks!!

@SKuipers SKuipers mentioned this issue Oct 15, 2019
Closed
3 tasks
@SKuipers SKuipers added this to General Roadmap in v20.0.00 (Ding Ding Che) Jan 17, 2020
@SKuipers SKuipers mentioned this issue Oct 4, 2020
Closed
@jimbo8098
Copy link
Contributor

If I'm not mistaken, it seems like the Help Desk module is already converted over to DataTables. I couldn't find any tables tags within that module.

@powertashton
Copy link
Member

@jimbo8098: If I'm not mistaken, it seems like the Help Desk module is already converted over to DataTables. I couldn't find any tables tags within that module.

@raynichc and I completely refactored the whole module, so you'd be right on that one.

@SKuipers
Copy link
Member Author

Yes, well spotted, I've checked the Help Desk off on the list 😄

@jimbo8098
Copy link
Contributor

FYI I've started work on the Trip Planner module's trips_manage.php page @raynichc

@SKuipers SKuipers added this to To do in v21.0.00 (Ee Gah) Nov 13, 2020
@SKuipers SKuipers moved this from To do to General Roadmap in v21.0.00 (Ee Gah) Nov 13, 2020
@leofreitas
Copy link
Member

Hi, finished Alumni.

@powertashton powertashton mentioned this issue Dec 23, 2020
Merged
@SKuipers
Copy link
Member Author

SKuipers commented Jan 4, 2021

Hi, finished Alumni.

Thanks Leo! 👍

@SKuipers SKuipers mentioned this issue Oct 3, 2021
Closed
@yookoala
Copy link
Member

Questions about the remaining modules:

  1. IB Diploma module is archived. Does it still needed to be refactored?
  2. Is there any link to the source code of "Course Selection"?
  3. Seems all left in ATL to refactor is alt_write.php and moduleFunctions.php, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
No open projects
v18.0.00 (Bo Lo Bao)
  
General Roadmap
v19.0.00 (Cha Chaan Teng)
  
General Roadmap
v20.0.00 (Ding Ding Che)
  
General Roadmap
v21.0.00 (Ee Gah)
  
General Roadmap
Milestone
No milestone
Development

No branches or pull requests
6 participants
@yookoala @SKuipers @leofreitas @rossdotparker @jimbo8098 @powertashton