Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reafactoring Breadcrumbs #696

Closed
39 tasks done
SKuipers opened this issue Nov 7, 2018 · 38 comments
Closed
39 tasks done

Reafactoring Breadcrumbs #696

SKuipers opened this issue Nov 7, 2018 · 38 comments

Comments

@SKuipers
Copy link
Member

SKuipers commented Nov 7, 2018

We've updated the breadcrumbs in Gibbon and there's a lot of pages to refactor. Here's some info if you'd like to help out:

👀 Check out the instructions

👇 Pick a module that hasn't been started yet

💬 Reply here to let us know which module you're working on, so we don't overlap!

:octocat: PR your changes when they're done, ideally one PR per module

Thanks! Give a shout with any questions.

Core Modules

Additional Modules

@yookoala
Copy link
Member

yookoala commented Nov 7, 2018

I'm working on the Attendance module.

@rossdotparker
Copy link
Member

This is a great way to organise the refactoring work @SKuipers : ) I'll aim to merge the work of @leofreitas and @yookoala this evening. Ciao!

@yookoala
Copy link
Member

yookoala commented Nov 7, 2018

I'm going to work on these (if nobody else has already start working on):

  • Library
  • Markbook
  • Messenger
  • Planner
  • Roll Groups

@SKuipers
Copy link
Member Author

SKuipers commented Nov 8, 2018

Added a new note to the instructions:

  • Delete actions are handled with a modal window, so the breadcrumbs for these can be removed rather than refactored

@leofreitas
Copy link
Member

leofreitas commented Nov 12, 2018

I started the module Behaviour

@leofreitas
Copy link
Member

I started the module Crowd Assessment

@yookoala
Copy link
Member

yookoala commented Nov 16, 2018

I'm going to work on these (if nobody else has already start working on):

  • Rubrics
  • School Admin
  • Staff
  • Students
  • System Admin

@leofreitas
Copy link
Member

Now, I started - Data Updater

@leofreitas
Copy link
Member

The next module is Departments

@SKuipers
Copy link
Member Author

Over half way 🎉 😃

@yookoala
Copy link
Member

yookoala commented Nov 21, 2018

I'm going to work on these (if nobody else has already start working on):

  • Timetable
  • Timetable Admin
  • Tracking

@SKuipers SKuipers added this to In Progress in v18.0.00 (Bo Lo Bao) Jan 20, 2019
@leofreitas
Copy link
Member

Hi devs,
Module MeetTheTeacher - refactored breadcrumbs!

@leofreitas
Copy link
Member

Hi,
Module Badges - refactored breadcrumbs!

@rossdotparker
Copy link
Member

@leofreitas I've checked it off the list.

@yookoala
Copy link
Member

yookoala commented Mar 6, 2019

The Help Desk module seems to be inactive since Apr 2018...

@raynichc
Copy link
Contributor

raynichc commented Mar 6, 2019

The Help Desk and Trip Planner have both temporarily been put on hold until I am able to get adjusted to University. But I intend to rebuild the Help Desk from the ground up, starting hopefully sometime this month or the next. If there are any major issues with either I can look into them, but any help would be appreciated.

Thanks,
Ray

@yookoala
Copy link
Member

yookoala commented Mar 6, 2019

Thanks @raynichc!

Please state the help you needed. I'll try to help.

@yookoala
Copy link
Member

yookoala commented Mar 6, 2019

I'm going to work on these (if nobody else has already start working on):

  • Higher Education
  • Info Grid
  • Trip Planner

@SKuipers
Copy link
Member Author

SKuipers commented Mar 6, 2019

Thanks Koala! I've updated the checklist 👍

Hi Ray, thanks for the followup! Hope you're having a great time at university 😃

@rossdotparker
Copy link
Member

rossdotparker commented Mar 6, 2019 via email

@leofreitas
Copy link
Member

leofreitas commented Mar 10, 2019

I'm working in module Policies (refatoring breadcrumbs and OOified)

@rossdotparker
Copy link
Member

rossdotparker commented Mar 21, 2019 via email

@SKuipers SKuipers mentioned this issue Mar 26, 2019
25 tasks
@SKuipers SKuipers pinned this issue Mar 26, 2019
@leofreitas
Copy link
Member

Hi, I refatored breadcrumbs in module Policies (GibbonEdu/module-policies#3)

@SKuipers
Copy link
Member Author

Hi @powertashton I've added IB Diploma to the list, looks like it's the last additional module needing its breadcrumbs refactored. Interested in tackling them? They're much easier than forms 😁

@jimbo8098
Copy link
Contributor

Ah, this looks not too bad. I'll grab IB Diploma

@powertashton
Copy link
Member

@jimbo8098 I've actually just started on them, and am almost done. Will be making a pull request in a few. Forgot to comment earlier when I started 😳

@jimbo8098
Copy link
Contributor

I see that now haha nice work.

@SKuipers
Copy link
Member Author

Wow!!! 😃 Thanks everyone for your hard work on these, we've now completed all the breadcrumb refactoring 🎉 🍰

JS51011859

@SKuipers SKuipers unpinned this issue Apr 23, 2019
@rossdotparker
Copy link
Member

Now there's a happy looking Gibbon. This achievement is a testament to the growing number of wonderful code contributors we have. A year ago this kind of collaboration was simply not possible on this project. Thank you so much everyone : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v17.0.00
In progress
v18.0.00 (Bo Lo Bao)
  
In Progress
Development

No branches or pull requests

7 participants