Implement Bedrock player collision (pushing) #1357
Draft
144
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike fishing rod pulling behavior that is calculated serverside on Bedrock and clientside on Java, Bedrock player "pushing" is nonexistent on Bedrock. This code checks to see if a Geyser player should be moved, and if so applies motion to the player which sends movement packets back. This commit also cleans up the move relative code of villagers so they aren't always checking the chunk cache.
Camotoy
changed the title
Redned235
requested changes
Oct 3, 2020
connector/src/main/java/org/geysermc/connector/entity/Entity.java
Outdated
Show resolved
Hide resolved
lukeeey
reviewed
Oct 3, 2020
| } | ||
|
|
||
| /** | ||
| * Teleports an entity to a new location. Used in JavaEntityTeleportTranslator. | ||
| * Teleports an entity to a new location. Used in {@link org.geysermc.connector.network.translators.java.entity.JavaEntityTeleportTranslator}. |
There was a problem hiding this comment.
I would just import these, it’s much cleaner.
There was a problem hiding this comment.
Yes, intellij should give you a context action to do if
Camotoy
added
PR: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't perfect! Feel free to play around and critique the code. I'm no expert in collisions, however; I have to thank
pokechu22for giving me some excellent reference code to work with.Unlike fishing rod pulling behavior that is calculated serverside on Bedrock and clientside on Java, Bedrock player "pushing" is nonexistent on Bedrock. This code checks to see if a Geyser player should be moved, and if so applies motion to the player which sends movement packets back.
This commit also cleans up the move relative code of villagers so they aren't always checking the chunk cache.