Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pagination #30

Merged
merged 7 commits into from
Nov 5, 2018
Merged

Adds Pagination #30

merged 7 commits into from
Nov 5, 2018

Conversation

dajocarter
Copy link
Contributor

No description provided.

@chmac
Copy link
Collaborator

chmac commented Nov 1, 2018

@dajocarter Love the pagination approach, it’s almost exactly what we do in the gatsby-awesome-pagination plugin. There’s a few advantages to using that plugin, it supports some odd edge cases that folks might want.

I really appreciate all the code you’re putting into the starter, just pinged you an email hoping to connect for a quick call so we can synchronise a bit around coding styles, etc. :-)

@chmac chmac merged commit afdfb13 into GatsbyCentral:master Nov 5, 2018
@chmac
Copy link
Collaborator

chmac commented Nov 5, 2018

@dajocarter Thanks for the refactor on this, code looks great. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants