Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand group value testing #351

Merged
merged 3 commits into from
Feb 13, 2023
Merged

expand group value testing #351

merged 3 commits into from
Feb 13, 2023

Conversation

thebioengineer
Copy link
Collaborator

Add to the group value check row_grp_plan and footnote_plan. Simplify messaging when there is a malformed group.

Resolves #349

@thebioengineer
Copy link
Collaborator Author

This passed locally, I think this is more of a sign of breaking changes to other components due to updates to dplyr/tidyverse

@codecov-commenter
Copy link

Codecov Report

Merging #351 (6ef8861) into main (06c98dd) will decrease coverage by 0.37%.
The diff coverage is 94.11%.

❗ Current head 6ef8861 differs from pull request most recent head e66b774. Consider uploading reports for the commit e66b774 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351       /-   ##
==========================================
- Coverage   95.24%   94.87%   -0.37%     
==========================================
  Files          27       28        1     
  Lines        2229     2361      132     
==========================================
  Hits         2123     2240      117     
- Misses        106      121       15     
Impacted Files Coverage Δ
R/frmt_utils.R 84.52% <0.00%> (-7.05%) ⬇️
R/row_group_plan.R 76.19% <ø> (ø)
R/tfrmt.R 94.78% <ø> (ø)
R/JSON.R 84.21% <84.21%> (ø)
R/apply_col_plan.R 96.10% <100.00%> (ø)
R/apply_footnote_meta.R 90.83% <100.00%> ( 0.07%) ⬆️
R/apply_row_grp_plan.R 100.00% <100.00%> (ø)
R/apply_table_frmt_plan.R 98.01% <100.00%> (ø)
R/apply_tfrmt.R 98.55% <100.00%> ( 0.02%) ⬆️
R/frmt_plans.R 88.88% <100.00%> ( 0.20%) ⬆️
... and 3 more

@statasaurus statasaurus merged commit d7a365d into main Feb 13, 2023
@statasaurus statasaurus deleted the broader_update_groups branch February 13, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update update_group to check more plans in tfrmt for consistency
3 participants