Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for dev dplyr #346

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Fix for dev dplyr #346

merged 7 commits into from
Feb 8, 2023

Commits on Dec 15, 2022

  1. Unname since if_else() propagates names now

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c7ac0fc View commit details
    Browse the repository at this point in the history

  2. Convert to character early

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    45ce662 View commit details
    Browse the repository at this point in the history

  3. Use any() in case there are multiple warnings

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    05087d3 View commit details
    Browse the repository at this point in the history

  4. Convert from matrix to vector

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e49b8c9 View commit details
    Browse the repository at this point in the history

  5. Override ordering early 

    Since `distinct()` respects requested order now
    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f0f436c View commit details
    Browse the repository at this point in the history

  6. Switch to more precise expect_no_message()

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    863fe3b View commit details
    Browse the repository at this point in the history

  7. Use a less fragile snapshot test

    @DavisVaughan
    DavisVaughan committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    868e918 View commit details
    Browse the repository at this point in the history